borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
9
74
Fork 55
Code Issues 52 Pull requests 4 Releases 159 Packages 1 Activity Actions 1

Filtering on can_mount == 'on' prevents backing up root ZFS datasets #1269

New issue
Closed
opened 2026-02-15 18:35:37 +00:00 by dan.groshev · 4 comments
dan.groshev commented 2026-02-15 18:35:37 +00:00
Copy link

What I'm trying to do and why

I'm trying to back up a root ZFS dataset after following the official guide.

I marked rpool with org.torsion.borgmatic:backup=auto, which makes the rest of the datasets inherit the marker. However, with --verbose 2 I can see that while borgmatic mounts datasets, it skips rpool/ROOT/debian mounted on root.

After looking through the code, I think I know the reason:

Line 74 in d532fc0
if can_mount == 'on'

The datasets are filtered with can_mount == 'on', rather than with can_mount != 'off'. My root dataset (rpool/ROOT/debian) has canmount == 'noauto', so while it can be mounted, it is still skipped as if it's unmountable.

borgmatic version

1.9.14

borgmatic installation method

Debian package

Borg version

1.4.0

Python version

3.13.5

Operating system and version

Debian GNU/Linux 13 (trixie)

### What I'm trying to do and why I'm trying to back up a root ZFS dataset after following [the official guide](https://openzfs.github.io/openzfs-docs/Getting%20Started/Debian/Debian%20Trixie%20Root%20on%20ZFS.html). I marked `rpool` with `org.torsion.borgmatic:backup=auto`, which makes the rest of the datasets inherit the marker. However, with `--verbose 2` I can see that while borgmatic mounts datasets, it skips `rpool/ROOT/debian` mounted on `root`. After looking through the code, I think I know the reason: https://projects.torsion.org/borgmatic-collective/borgmatic/src/commit/d532fc0f88f0999ed473eda6d58aef424c4f0286/borgmatic/hooks/data_source/zfs.py#L74 The datasets are filtered with `can_mount == 'on'`, rather than with `can_mount != 'off'`. My root dataset (`rpool/ROOT/debian`) has `canmount == 'noauto'`, so while it can be mounted, it is still skipped as if it's unmountable. ### borgmatic version 1.9.14 ### borgmatic installation method Debian package ### Borg version 1.4.0 ### Python version 3.13.5 ### Operating system and version Debian GNU/Linux 13 (trixie)
witten commented 2026-02-15 19:07:46 +00:00
Owner
Copy link

Thanks for filing this with all of the details! It's fixed in main now and will be part of the next release.

Thanks for filing this with all of the details! It's fixed in main now and will be part of the next release.
dan.groshev commented 2026-02-15 19:08:36 +00:00
Author
Copy link

That's was insanely quick haha. Thank you!

That's was _insanely_ quick haha. Thank you!
witten commented 2026-02-15 19:30:44 +00:00
Owner
Copy link

Caught me at a good time!

Caught me at a good time!
witten commented 2026-03-06 18:24:37 +00:00
Owner
Copy link

Released in borgmatic 2.1.3!

Released in borgmatic 2.1.3!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
command-hook-steps
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.9.14
1.9.13
1.9.12
1.9.11
1.9.10
1.9.9
1.9.8
1.9.7
1.9.6
1.9.5
1.9.4
1.9.3
1.9.2
1.9.1
1.9.0
1.8.14
1.8.13
1.8.12
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
borgmatic-collective/borgmatic#1269
No description provided.