Add Borg 1.4.2 features #1175
Labels
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
borgmatic-collective/borgmatic#1175
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'd like to do and why
Add relevant Borg 1.4.2 features to be wrapped in borgmatic:
This could be a borgmatic configuration option that sets an environment variable when invoking Borg. Lots of existing examples of that.
This could be a configuration option as well.
Other notes / implementation ideas
No response
Hey! I'm a beginner in open source (Coming over from GSoC) and I'd love to work on this issue. I have implemented the '--files-changed=MODE' flag already, however I'm not sure where to get started on the MSGPACK one.
Welcome! So the existing examples for borgmatic options that set environment variables passed to Borg are here: https://projects.torsion.org/borgmatic-collective/borgmatic/src/branch/main/borgmatic/borg/environment.py#L6 ... And then you can create a new option in schema.yaml. Also check out the source code reference if you haven't already. Let me know if you have any questions.
Note that borgmatic isn't participating in GSoC this year, but you are still more than welcome to submit PRs.
That's fine, I still managed to get valuable experience regarding contributing. I've submitted a PR (correctly I hope?) and I'd like to
know if theres any corrections.
Thanks again! This is merged in main and will be part of the next release.
Released in borgmatic 2.1.3!