New --extra-borg-options.list option is being ignored on the command line #1168
Labels
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
borgmatic-collective/borgmatic#1168
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
This is followup on issue #427 which was resolved in 2.0.10.
I believe the argument to
--extra-borg-options.listis not being passed to theborgcommand.Steps to reproduce
Actual behavior
The
listoperation runs ignoring--extra-borg-options.listExpected behavior
Similar to this, where an error is thrown by
borg:Other notes / implementation ideas
No response
borgmatic version
2.0.10
borgmatic installation method
pip install
Borg version
borg 1.4.1
Python version
Python 3.13.7
Database version (if applicable)
No response
Operating system and version
NAME="Manjaro Linux" PRETTY_NAME="Manjaro Linux" ID=manjaro ID_LIKE=arch BUILD_ID=rolling ANSI_COLOR="32;1;24;144;200" HOME_URL="https://manjaro.org/" DOCUMENTATION_URL="https://wiki.manjaro.org/" SUPPORT_URL="https://forum.manjaro.org/" BUG_REPORT_URL="https://manjaro.org/help/" PRIVACY_POLICY_URL="https://manjaro.org/privacy-policy/" LOGO=manjarolinux
Ugh, thanks for filing this. I think what's going on is that borgmatic is applying
extra_borg_options.listwhen--archiveis specified, but not when you omit it. That's becauselistwithout--archiveis actually consideredrepo-listunder the hood (and so uses the correspondingextra_borg_options), whilelistwith--archiveis considered justlist(and uses those correspondingextra_borg_options). This nuance is in place because Borg 2 (which you're not using) has completely separatelistandrepo-listsub-commands, so borgmatic tries to work like that while still supporting Borg 1list-only semantics.Anyway, this
extra_borg_optionsbehavior withlistandrepo_listshould probably not work like it does now, because it's kind of surprising for Borg 1 users—as you've discovered. I'll look into what I can do about that. (Note to the implementer: This same issue applies toinfo/repo-infoanddelete/repo-delete.)In the meantime, you can try setting your extra Borg options with
--extra-borg-options.repo-liston the command-line orextra_borg_options->repo_listin configuration. That should work whenever--archiveis omitted.Okay, this is fixed in main and will be part of the next release. At that point, you'll be able to use
--extra-borg-options.listwith Borg 1.x again even when--archiveis omitted.Thanks again!
ty!
Released in borgmatic 2.0.11!
Confirming this fix does work in my environment. Thanks.
Great, glad to hear it!