borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
Watch
9
74
Fork
You've already forked borgmatic
 57
Code Issues 71 Pull requests 3 Releases 162 Packages 1 Activity Actions 1

Cannot dry-run with LVM #1093

New issue
Closed
opened 2025-05-12 05:37:37 +00:00 by jacksonchen666 · 3 comments
jacksonchen666 commented 2025-05-12 05:37:37 +00:00
Contributor
Copy link

What I'm trying to do and why

I'm trying to run a dry-run of borgmatic by running borgmatic -n. It cannot go through all the steps, and instead tries again. Until it fails.

Steps to reproduce

  1. Have LVM snapshots setup
  2. run borgmatic -n
  3. Experience issue

Actual behavior

Running 2 commands for pre-everything hook (dry run; not actually running hooks)
Set hook umask to 0o22
/etc/borgmatic/config.yaml: Calling file hook function load_credential
/etc/borgmatic/config.yaml: BORG_PASSPHRASE_FD=*** BORG_RELOCATED_REPO_ACCESS_IS_OK=*** BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK=*** BORG_CHECK_I_KNOW_WHAT_I_AM_DOING=*** BORG_EXIT_CODES=*** borg --version --debug --show-rc
/etc/borgmatic/config.yaml: Borg 1.4.0
/etc/borgmatic/config.yaml: Calling ntfy hook function initialize_monitor
/etc/borgmatic/config.yaml: Calling ntfy hook function ping_monitor
/etc/borgmatic/config.yaml: Pinging ntfy topic backup-flattop (dry run; not actually pinging)
/etc/borgmatic/config.yaml: Using Ntfy ping URL https://ntfy.jacksonchen666.com/backup-flattop
/etc/borgmatic/config.yaml: Calling file hook function load_credential
borgbase: Running actions for repository
borgbase: No commands to run for pre-actions hook
borgbase: No commands to run for pre-backup hook
borgbase: Creating archive (dry run; not making any changes)
borgbase: Using runtime directory /root/backups/borgmatic
borgbase: Calling bootstrap hook function remove_data_source_dumps
borgbase: Looking for bootstrap manifest files to remove in /root/backups/borgmatic/bootstrap (dry run; not actually removing anything)
borgbase: Removing bootstrap manifest at /root/backups/borgmatic/bootstrap/manifest.json (dry run; not actually removing anything)
borgbase: Calling btrfs hook function remove_data_source_dumps
borgbase: Calling lvm hook function remove_data_source_dumps
borgbase: lsblk --output name,path,mountpoint,type --json --list
borgbase: Looking for snapshots to remove in /root/backups/borgmatic/lvm_snapshots/* (dry run; not actually removing anything)
borgbase: Unmounting LVM snapshot at /root/backups/borgmatic/lvm_snapshots/3751af5bd81011e6d21d/ (dry run; not actually removing anything)
borgbase: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s
File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3
borgbase: Deleting LVM snapshot alpine-root_borgmatic-17895 (dry run; not actually removing anything)
borgbase: Calling mariadb hook function remove_data_source_dumps
borgbase: Removing MariaDB data source dumps (dry run; not actually removing anything)
borgbase: Calling mongodb hook function remove_data_source_dumps
borgbase: Removing MongoDB data source dumps (dry run; not actually removing anything)
borgbase: Calling mysql hook function remove_data_source_dumps
borgbase: Removing MySQL data source dumps (dry run; not actually removing anything)
borgbase: Calling postgresql hook function remove_data_source_dumps
borgbase: Removing PostgreSQL data source dumps (dry run; not actually removing anything)
borgbase: Calling sqlite hook function remove_data_source_dumps
borgbase: Removing SQLite data source dumps (dry run; not actually removing anything)
borgbase: Calling zfs hook function remove_data_source_dumps
borgbase: Calling bootstrap hook function dump_data_sources
borgbase: Calling lvm hook function dump_data_sources
borgbase: Snapshotting LVM logical volumes (dry run; not actually snapshotting anything)
borgbase: lsblk --output name,path,mountpoint,type --json --list
borgbase: Creating LVM snapshot alpine-root_borgmatic-18082 of / (dry run; not actually snapshotting anything)
borgbase: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s
File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3
borgbase: Error running actions for repository
borgbase: Cannot find LVM snapshot alpine-root_borgmatic-18082
borgbase: Retrying... attempt 1/3
flattop-external-drives: Running actions for repository
flattop-external-drives: No commands to run for pre-actions hook
flattop-external-drives: No commands to run for pre-backup hook
flattop-external-drives: Creating archive (dry run; not making any changes)
flattop-external-drives: Using runtime directory /root/backups/borgmatic
flattop-external-drives: Calling bootstrap hook function remove_data_source_dumps
flattop-external-drives: Looking for bootstrap manifest files to remove in /root/backups/borgmatic/bootstrap (dry run; not actually removing anything)
flattop-external-drives: Removing bootstrap manifest at /root/backups/borgmatic/bootstrap/manifest.json (dry run; not actually removing anything)
flattop-external-drives: Calling btrfs hook function remove_data_source_dumps
flattop-external-drives: Calling lvm hook function remove_data_source_dumps
flattop-external-drives: lsblk --output name,path,mountpoint,type --json --list
flattop-external-drives: Looking for snapshots to remove in /root/backups/borgmatic/lvm_snapshots/* (dry run; not actually removing anything)
flattop-external-drives: Unmounting LVM snapshot at /root/backups/borgmatic/lvm_snapshots/3751af5bd81011e6d21d/ (dry run; not actually removing anything)
flattop-external-drives: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s
File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3
flattop-external-drives: Deleting LVM snapshot alpine-root_borgmatic-17895 (dry run; not actually removing anything)
flattop-external-drives: Calling mariadb hook function remove_data_source_dumps
flattop-external-drives: Removing MariaDB data source dumps (dry run; not actually removing anything)
flattop-external-drives: Calling mongodb hook function remove_data_source_dumps
flattop-external-drives: Removing MongoDB data source dumps (dry run; not actually removing anything)
flattop-external-drives: Calling mysql hook function remove_data_source_dumps
flattop-external-drives: Removing MySQL data source dumps (dry run; not actually removing anything)
flattop-external-drives: Calling postgresql hook function remove_data_source_dumps
flattop-external-drives: Removing PostgreSQL data source dumps (dry run; not actually removing anything)
flattop-external-drives: Calling sqlite hook function remove_data_source_dumps
flattop-external-drives: Removing SQLite data source dumps (dry run; not actually removing anything)
flattop-external-drives: Calling zfs hook function remove_data_source_dumps
flattop-external-drives: Calling bootstrap hook function dump_data_sources
flattop-external-drives: Calling lvm hook function dump_data_sources
flattop-external-drives: Snapshotting LVM logical volumes (dry run; not actually snapshotting anything)
flattop-external-drives: lsblk --output name,path,mountpoint,type --json --list
flattop-external-drives: Creating LVM snapshot alpine-root_borgmatic-18082 of / (dry run; not actually snapshotting anything)
flattop-external-drives: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s
File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3
flattop-external-drives: Error running actions for repository
flattop-external-drives: Cannot find LVM snapshot alpine-root_borgmatic-18082
flattop-external-drives: Retrying... attempt 1/3
borgbase: Running actions for repository
borgbase: Sleeping 10s before next retry

Expected behavior

borgmatic handles whatever the issue is (lacking LVM snapshots) in dry-run mode and proceeds with the dry-run

Other notes / implementation ideas

No response

borgmatic version

1.9.14

borgmatic installation method

Alpine Linux

Borg version

borg 1.4.0

Python version

Python 3.12.10

Database version (if applicable)

No response

Operating system and version

Alpine Linux v3.21

### What I'm trying to do and why I'm trying to run a dry-run of borgmatic by running `borgmatic -n`. It cannot go through all the steps, and instead tries again. Until it fails. ### Steps to reproduce 1. Have LVM snapshots setup 2. run `borgmatic -n` 3. Experience issue ### Actual behavior ``` Running 2 commands for pre-everything hook (dry run; not actually running hooks) Set hook umask to 0o22 /etc/borgmatic/config.yaml: Calling file hook function load_credential /etc/borgmatic/config.yaml: BORG_PASSPHRASE_FD=*** BORG_RELOCATED_REPO_ACCESS_IS_OK=*** BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK=*** BORG_CHECK_I_KNOW_WHAT_I_AM_DOING=*** BORG_EXIT_CODES=*** borg --version --debug --show-rc /etc/borgmatic/config.yaml: Borg 1.4.0 /etc/borgmatic/config.yaml: Calling ntfy hook function initialize_monitor /etc/borgmatic/config.yaml: Calling ntfy hook function ping_monitor /etc/borgmatic/config.yaml: Pinging ntfy topic backup-flattop (dry run; not actually pinging) /etc/borgmatic/config.yaml: Using Ntfy ping URL https://ntfy.jacksonchen666.com/backup-flattop /etc/borgmatic/config.yaml: Calling file hook function load_credential borgbase: Running actions for repository borgbase: No commands to run for pre-actions hook borgbase: No commands to run for pre-backup hook borgbase: Creating archive (dry run; not making any changes) borgbase: Using runtime directory /root/backups/borgmatic borgbase: Calling bootstrap hook function remove_data_source_dumps borgbase: Looking for bootstrap manifest files to remove in /root/backups/borgmatic/bootstrap (dry run; not actually removing anything) borgbase: Removing bootstrap manifest at /root/backups/borgmatic/bootstrap/manifest.json (dry run; not actually removing anything) borgbase: Calling btrfs hook function remove_data_source_dumps borgbase: Calling lvm hook function remove_data_source_dumps borgbase: lsblk --output name,path,mountpoint,type --json --list borgbase: Looking for snapshots to remove in /root/backups/borgmatic/lvm_snapshots/* (dry run; not actually removing anything) borgbase: Unmounting LVM snapshot at /root/backups/borgmatic/lvm_snapshots/3751af5bd81011e6d21d/ (dry run; not actually removing anything) borgbase: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3 borgbase: Deleting LVM snapshot alpine-root_borgmatic-17895 (dry run; not actually removing anything) borgbase: Calling mariadb hook function remove_data_source_dumps borgbase: Removing MariaDB data source dumps (dry run; not actually removing anything) borgbase: Calling mongodb hook function remove_data_source_dumps borgbase: Removing MongoDB data source dumps (dry run; not actually removing anything) borgbase: Calling mysql hook function remove_data_source_dumps borgbase: Removing MySQL data source dumps (dry run; not actually removing anything) borgbase: Calling postgresql hook function remove_data_source_dumps borgbase: Removing PostgreSQL data source dumps (dry run; not actually removing anything) borgbase: Calling sqlite hook function remove_data_source_dumps borgbase: Removing SQLite data source dumps (dry run; not actually removing anything) borgbase: Calling zfs hook function remove_data_source_dumps borgbase: Calling bootstrap hook function dump_data_sources borgbase: Calling lvm hook function dump_data_sources borgbase: Snapshotting LVM logical volumes (dry run; not actually snapshotting anything) borgbase: lsblk --output name,path,mountpoint,type --json --list borgbase: Creating LVM snapshot alpine-root_borgmatic-18082 of / (dry run; not actually snapshotting anything) borgbase: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3 borgbase: Error running actions for repository borgbase: Cannot find LVM snapshot alpine-root_borgmatic-18082 borgbase: Retrying... attempt 1/3 flattop-external-drives: Running actions for repository flattop-external-drives: No commands to run for pre-actions hook flattop-external-drives: No commands to run for pre-backup hook flattop-external-drives: Creating archive (dry run; not making any changes) flattop-external-drives: Using runtime directory /root/backups/borgmatic flattop-external-drives: Calling bootstrap hook function remove_data_source_dumps flattop-external-drives: Looking for bootstrap manifest files to remove in /root/backups/borgmatic/bootstrap (dry run; not actually removing anything) flattop-external-drives: Removing bootstrap manifest at /root/backups/borgmatic/bootstrap/manifest.json (dry run; not actually removing anything) flattop-external-drives: Calling btrfs hook function remove_data_source_dumps flattop-external-drives: Calling lvm hook function remove_data_source_dumps flattop-external-drives: lsblk --output name,path,mountpoint,type --json --list flattop-external-drives: Looking for snapshots to remove in /root/backups/borgmatic/lvm_snapshots/* (dry run; not actually removing anything) flattop-external-drives: Unmounting LVM snapshot at /root/backups/borgmatic/lvm_snapshots/3751af5bd81011e6d21d/ (dry run; not actually removing anything) flattop-external-drives: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3 flattop-external-drives: Deleting LVM snapshot alpine-root_borgmatic-17895 (dry run; not actually removing anything) flattop-external-drives: Calling mariadb hook function remove_data_source_dumps flattop-external-drives: Removing MariaDB data source dumps (dry run; not actually removing anything) flattop-external-drives: Calling mongodb hook function remove_data_source_dumps flattop-external-drives: Removing MongoDB data source dumps (dry run; not actually removing anything) flattop-external-drives: Calling mysql hook function remove_data_source_dumps flattop-external-drives: Removing MySQL data source dumps (dry run; not actually removing anything) flattop-external-drives: Calling postgresql hook function remove_data_source_dumps flattop-external-drives: Removing PostgreSQL data source dumps (dry run; not actually removing anything) flattop-external-drives: Calling sqlite hook function remove_data_source_dumps flattop-external-drives: Removing SQLite data source dumps (dry run; not actually removing anything) flattop-external-drives: Calling zfs hook function remove_data_source_dumps flattop-external-drives: Calling bootstrap hook function dump_data_sources flattop-external-drives: Calling lvm hook function dump_data_sources flattop-external-drives: Snapshotting LVM logical volumes (dry run; not actually snapshotting anything) flattop-external-drives: lsblk --output name,path,mountpoint,type --json --list flattop-external-drives: Creating LVM snapshot alpine-root_borgmatic-18082 of / (dry run; not actually snapshotting anything) flattop-external-drives: lvs --report-format json --options lv_name,lv_path --select lv_attr =~ ^s File descriptor 3 (pipe:[5930347]) leaked on lvs invocation. Parent PID 18082: /usr/bin/python3 flattop-external-drives: Error running actions for repository flattop-external-drives: Cannot find LVM snapshot alpine-root_borgmatic-18082 flattop-external-drives: Retrying... attempt 1/3 borgbase: Running actions for repository borgbase: Sleeping 10s before next retry ``` ### Expected behavior borgmatic handles whatever the issue is (lacking LVM snapshots) in dry-run mode and proceeds with the dry-run ### Other notes / implementation ideas _No response_ ### borgmatic version 1.9.14 ### borgmatic installation method Alpine Linux ### Borg version borg 1.4.0 ### Python version Python 3.12.10 ### Database version (if applicable) _No response_ ### Operating system and version Alpine Linux v3.21
witten commented 2025-05-12 05:47:20 +00:00
Owner
Copy link

Thanks for filing this. Looking at the code, it appears that borgmatic is being a little too optimistic in what LVM hook code it's running during a dry run. Fortunately, the fix looks pretty straightforward: during a dry run, skip slightly more code than is being skipped now.

Thanks for filing this. Looking at the code, it appears that borgmatic is being a little too optimistic in what LVM hook code it's running during a dry run. Fortunately, the fix looks pretty straightforward: during a dry run, skip slightly more code than is being skipped now.
witten commented 2025-05-12 18:51:20 +00:00
Owner
Copy link

This is fixed in main and will be part of the next release!

This is fixed in main and will be part of the next release!
witten commented 2025-05-16 16:37:40 +00:00
Owner
Copy link

Released in borgmatic 2.0.6!

Released in borgmatic 2.0.6!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
parallel-borgmatic
command-hook-steps
2.1.7
2.1.6
2.1.5
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.9.14
1.9.13
1.9.12
1.9.11
1.9.10
1.9.9
1.9.8
1.9.7
1.9.6
1.9.5
1.9.4
1.9.3
1.9.2
1.9.1
1.9.0
1.8.14
1.8.13
1.8.12
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
borgmatic-collective/borgmatic#1093
No description provided.