Add Borg 1.4.1 feaures #1078

New issue

Closed

opened 2025-04-19 00:19:17 +00:00 by witten · 6 comments

witten commented 2025-04-19 00:19:17 +00:00

Owner

Copy link

What I'd like to do and why

Support relevant Borg 1.4.1 features and changes natively in borgmatic:

• prune: add 13weekly and 3monthly quarterly pruning strategies
  • Maybe add borgmatic configuration options for these?
• add BORG_USE_CHUNKS_ARCHIVE env var as a cleaner way to control whether borg shall use chunks.archive.d/ cache directory. the previous “hack” to create a non-directory file at that place is still supported.
  • Maybe add a borgmatic configuration option for this, similar to the existing options that get converted to env vars?
• compact: support --dry-run (do nothing) to simplify scripting
  • Note: This would have to be added to borgmatic in a backwards compatible way so as not to break use of Borg 1.2.x and 1.4.0. Also check whether this is present with Borg 2.0 and support accordingly.

Other notes / implementation ideas

No response

### What I'd like to do and why Support relevant [Borg 1.4.1 features and changes](https://borgbackup.readthedocs.io/en/1.4.1/changes.html#version-1-4-1-2025-04-19) natively in borgmatic: * [ ] prune: add 13weekly and 3monthly quarterly pruning strategies * Maybe add borgmatic configuration options for these? * [ ] add BORG_USE_CHUNKS_ARCHIVE env var as a cleaner way to control whether borg shall use chunks.archive.d/ cache directory. the previous “hack” to create a non-directory file at that place is still supported. * Maybe add a borgmatic configuration option for this, similar to the existing options that get converted to env vars? * [ ] compact: support --dry-run (do nothing) to simplify scripting * Note: This would have to be added to borgmatic in a backwards compatible way so as not to break use of Borg 1.2.x and 1.4.0. Also check whether this is present with Borg 2.0 and support accordingly. ### Other notes / implementation ideas _No response_

witten added the

good first issue

label 2025-04-19 00:19:17 +00:00

VandalByte commented 2025-04-19 04:52:09 +00:00

Contributor

Copy link

First: This requires only edits to to config right? Add those two options to the rest of the bunch?

Second: This needs the addition of a new env variable in environment.py, that takes the config value true/false from config right? Does it need any modification to borg compact?

Third: dry-run is currently implemented from config in borg compact so does this mean using the flag directly?
PS: I couldn't find --dry-run in borg2 common options. I will have to install borg2 in a VM and test it out.

First: This requires only edits to to config right? Add those two options to the rest of the [bunch](https://projects.torsion.org/VandalByte/borgmatic/commit/fdb08b6c56b7e2697b3b98e98b42a3d82763b07f)? Second: This needs the addition of a new env variable in `environment.py`, that takes the config value true/false from config right? Does it need any modification to `borg compact`? Third: dry-run is currently implemented from config in `borg compact` so does this mean using the flag directly? PS: I couldn't find `--dry-run` in [borg2 common options](https://borgbackup.readthedocs.io/en/master/usage/compact.html). I will have to install borg2 in a VM and test it out.

witten commented 2025-04-19 16:24:01 +00:00

Author

Owner

Copy link

First: This requires only edits to to config right? Add those two options to the rest of the bunch?

Edits to config and then passing the relevant flags to borg prune.

Second: This needs the addition of a new env variable in environment.py, that takes the config value true/false from config right? Does it need any modification to borg compact?

A new environment variable in environment.py, yes. But unless I'm missing something, I don't think it requires compact changes.

Third: dry-run is currently implemented from config in borg compact so does this mean using the flag directly?

I think it means passing --dry-run to borg compact, but only if the feature is available() in the current version of Borg in use.

PS: I couldn't find --dry-run in borg2 common options. I will have to install borg2 in a VM and test it out.

It might not be implemented yet in Borg 2.

> First: This requires only edits to to config right? Add those two options to the rest of the bunch? Edits to config and then passing the relevant flags to `borg prune`. > Second: This needs the addition of a new env variable in environment.py, that takes the config value true/false from config right? Does it need any modification to borg compact? A new environment variable in `environment.py`, yes. But unless I'm missing something, I don't think it requires `compact` changes. > Third: dry-run is currently implemented from config in borg compact so does this mean using the flag directly? I think it means passing `--dry-run` to `borg compact`, but only if the feature is `available()` in the current version of Borg in use. > PS: I couldn't find --dry-run in borg2 common options. I will have to install borg2 in a VM and test it out. It might not be implemented yet in Borg 2.

👍 1

VandalByte commented 2025-04-19 18:10:51 +00:00

Contributor

Copy link

If you haven't started the PR work for this yet, I'd be happy to take it on.

Edits to config and then passing the relevant flags to borg prune.

It's already being taken care of here, right?

borgmatic/borg/prune.py

Lines 28 to 32 in c3c37de

	flag_pairs = (
	('--' + option_name.replace('_', '-'), str(value))
	for option_name, value in config.items()
	if option_name.startswith('keep_') and option_name != 'keep_exclude_tags'
	)

If you haven't started the PR work for this yet, I'd be happy to take it on. > Edits to config and then passing the relevant flags to borg prune. It's already being taken care of here, right? https://projects.torsion.org/borgmatic-collective/borgmatic/src/commit/c3c37dee134606563cdc4e20f9d6a8b30e077ed6/borgmatic/borg/prune.py#L28-L32

witten commented 2025-04-19 22:41:06 +00:00

Author

Owner

Copy link

Oh good call.. I had forgotten about that code. Then yes, editing the configuration schema (and manually testing the new options) should be all that's necessary for this one!

I haven't started the PR on this one.. Feel free to take it!

Oh good call.. I had forgotten about that code. Then yes, editing the configuration schema (and manually testing the new options) should be all that's necessary for this one! I haven't started the PR on this one.. Feel free to take it!

VandalByte referenced this issue from a pull request that will close it, 2025-04-20 10:45:37 +00:00

Add Borg 1.4.1 features #1081

witten closed this issue 2025-04-25 19:02:28 +00:00

witten referenced this issue from a commit 2025-04-25 19:02:28 +00:00

Add Borg 1.4.1 features (#1078).

witten referenced this issue from a commit 2025-04-25 19:07:34 +00:00

Add Borg 1.4.1 features to NEWS (#1078).

witten commented 2025-04-25 19:07:59 +00:00

Author

Owner

Copy link

This is now implemented by @VandalByte in main and will be part of the next release!

This is now implemented by @VandalByte in main and will be part of the next release!

witten commented 2025-04-29 22:23:12 +00:00

Author

Owner

Copy link

Released in borgmatic 2.0.5!

Released in borgmatic 2.0.5!

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

parallel-borgmatic

command-hook-steps

2.1.7

2.1.6

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

blocked

  

breaking

  

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

borgmatic-collective/borgmatic#1078

No description provided.