Log output doesn't contain config filename anymore #1051
Labels
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
borgmatic-collective/borgmatic#1051
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
On my setup, borgmatic runs 6 different configuration files. In the past, the borgmatic output would contain 6 lines like this one:
This helped my inform my monitoring system that a certain backup job was successful.
A recent version of borgmatic has changed this output to 6 times this line:
I couldn't find why this change was made, but it has made monitoring my backups more difficult.
This is why I'm requesting to re-add the configuration filename to borgmatic's output.
Steps to reproduce
Run borgmatic with multiple configuration files.
Actual behavior
Backup job filename is not included in the output anymore.
Expected behavior
Backup job filename should still be included in the output.
Other notes / implementation ideas
No response
borgmatic version
1.9.14
borgmatic installation method
NixOS module
Borg version
1.4.0
Python version
3.12.9
Database version (if applicable)
No response
Operating system and version
NixOS 25.05 (Warbler) (unstable)
Thanks for filing this! I generally don't recommend parsing borgmatic's log output (except for
--jsonoutput), but I agree that this is a regression that should be fixed even just for uses cases like reading logs.So I've fixed it in main, and it'll be part of the next release! Note however that the filename is now at the start of the log message instead of the end, which is more consistent with other log messages.
Also: If there's anything borgmatic can do to make your monitoring use cases easier or more officially supported, please let me know! (Ideally on a separate ticket.) Maybe something like #617 would be useful.
Thank you for the quick answer and resolution! I'm already using
borgmatic rinfo --jsonfor getting repository info for my monitoring.What I wanted to accomplish here (and had accomplished before it changed) was a simple verification that the last backup run was successful for each config file (taken from journalctl).
The JSON output from #617 would indeed be very helpful as well. Possibly configured the same way as the third party monitoring integrations or like the hooks.
But I'm already happy with what I have now, so please don't sink any time into it for my sake. :)
Sounds good! Thanks for the additional context.
Released in borgmatic 2.0.0!
Awesome, thank you!