trouble with exclude_patterns #1021

New issue

Closed

opened 2025-03-09 16:08:43 +00:00 by robdavies · 6 comments

robdavies commented 2025-03-09 16:08:43 +00:00

Copy link

Hi

I'm having trouble with exclude_patterns, all of the excludes are being included in the backups. It used to work for me, I last made a backup a couple of borgmatic versions ago (just before .local/state was introduced). I have made a small change so don't know if its a change I made or a borgmatic change.

My exclude patters are :

exclude_patterns:
- ~/.config/borg
- ~/.local/state
- ~/.cache
- ~/.var/app//cache
- ~/.local/share/Trash
- ~/**/.dtrash
- ~/.mozilla/firefox//storage
- ~/.var/app//.mozilla/firefox//storage
- ~/.thunderbird//storage
- ~/.var/app//.thunderbird//storage
- ~/.thunderbird//ImapMail
- ~/.var/app//.thunderbird//ImapMail

I tried to change the firefox and thunderbird entries (see below) and that is when the problems started. I changed them back and the trouble continues.

- ~/**/.mozilla/firefox/*/storage
- ~/**/.thunderbird/*/storage
- ~/**/.thunderbird/*/ImapMail

Is there something I can do to fix/correct this?

Hi I'm having trouble with exclude_patterns, all of the excludes are being included in the backups. It used to work for me, I last made a backup a couple of borgmatic versions ago (just before .local/state was introduced). I have made a small change so don't know if its a change I made or a borgmatic change. My exclude patters are : exclude_patterns: - ~/.config/borg - ~/.local/state - ~/.cache - ~/.var/app/*/cache - ~/.local/share/Trash - ~/**/.dtrash - ~/.mozilla/firefox/*/storage - ~/.var/app/*/.mozilla/firefox/*/storage - ~/.thunderbird/*/storage - ~/.var/app/*/.thunderbird/*/storage - ~/.thunderbird/*/ImapMail - ~/.var/app/*/.thunderbird/*/ImapMail I tried to change the firefox and thunderbird entries (see below) and that is when the problems started. I changed them back and the trouble continues. - ~/**/.mozilla/firefox/*/storage - ~/**/.thunderbird/*/storage - ~/**/.thunderbird/*/ImapMail Is there something I can do to fix/correct this?

witten commented 2025-03-09 17:36:45 +00:00

Owner

Copy link

My guess is that support for ~ in exclude patterns was inadvertently broken by borgmatic 1.9.6—and initial testing seems to support that theory. You can verify this on your system by running borgmatic with --files and observing whether your expected files to exclude are actually excluded. And then if you change ~ to your actual home directory in the exclude_patterns, seeing whether that appears to fix the excluded files in --files output. ("x" indicates it's actually excluded.)

My guess is that support for `~` in exclude patterns was inadvertently broken by borgmatic 1.9.6—and initial testing seems to support that theory. You can verify this on your system by running borgmatic with `--files` and observing whether your expected files to exclude are actually excluded. And then if you change `~` to your actual home directory in the `exclude_patterns`, seeing whether that appears to fix the excluded files in `--files` output. ("x" indicates it's actually excluded.)

witten added the

bug

label 2025-03-09 17:36:56 +00:00

robdavies commented 2025-03-09 17:59:09 +00:00

Author

Copy link

Great thanks, I'll try that out. Can I use $HOME in exchange for ~ as the home directory in the config files?

Great thanks, I'll try that out. Can I use $HOME in exchange for ~ as the home directory in the config files?

witten commented 2025-03-09 18:25:33 +00:00

Owner

Copy link

You should be able to use ${HOME} for that, although this should hopefully be fixed soon and then you can continue using ~.

You should be able to use `${HOME}` for that, although this should hopefully be fixed soon and then you can continue using `~`.

witten referenced this issue from a commit 2025-03-09 20:36:11 +00:00

Fix a regression in which the "exclude_patterns" option didn't expand "~" (#1021).

witten commented 2025-03-09 20:36:42 +00:00

Owner

Copy link

This is fixed in main and will be part of the next release. Thanks for taking the time to report this!

This is fixed in main and will be part of the next release. Thanks for taking the time to report this!

witten closed this issue 2025-03-09 20:36:42 +00:00

witten commented 2025-03-10 17:30:06 +00:00

Owner

Copy link

Released in borgmatic 1.9.14!

Released in borgmatic 1.9.14!

robdavies commented 2025-03-10 17:41:59 +00:00

Author

Copy link

Thank you, that was quick.
You were right, when I replaced ~ with ${HOME} (in a test config file) and it worked. I can revert to using ~ and my original config file.

Thank you, that was quick. You were right, when I replaced ~ with ${HOME} (in a test config file) and it worked. I can revert to using ~ and my original config file.

👍 1

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

parallel-borgmatic

command-hook-steps

2.1.7

2.1.6

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

blocked

  

breaking

  

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

borgmatic-collective/borgmatic#1021

No description provided.