borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
Watch
9
74
Fork
You've already forked borgmatic
 57
Code Issues 71 Pull requests 3 Releases 162 Packages 1 Activity Actions 1

Borgmatic 1.9.11 compilation erros with Python 3.10 and 3.11 #1005

New issue
Closed
opened 2025-02-23 13:28:55 +00:00 by arkamar · 3 comments
arkamar commented 2025-02-23 13:28:55 +00:00
Copy link

I have noticed following errors while I was creating Gentoo package for Borgmatic 1.9.11. The issue was introduced in commit a0ba5b673b - Add credential loading from file, KeePassXC, and Docker/Podman secrets.. This happens only with Python 3.10.16 and 3.11.11, Python 3.12.9 and 3.13.2 seem to be ok.

python3.11 -m gpep517 install-wheel --destdir=/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install --interpreter=/usr/bin/python3.11 --prefix=/usr --optimize=all /var/tmp/portage/app-backup/borgmatic-1.9.11
/work/borgmatic-1.9.11_python3.11/wheel/borgmatic-1.9.11-py3-none-any.whl
2025-02-23 13:00:08,627 gpep517 INFO Installing /var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/wheel/borgmatic-1.9.11-py3-none-any.whl into /var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_p
ython3.11/install
*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py", line 24
    raise ValueError(f'Cannot load invalid secret name: "{' '.join(credential_parameters)}"')
                                                                                            ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py", line 24
    raise ValueError(f'Cannot load invalid secret name: "{' '.join(credential_parameters)}"')
                                                                                            ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py", line 24
    raise ValueError(f'Cannot load invalid secret name: "{' '.join(credential_parameters)}"')
                                                                                            ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py", line 18
    raise ValueError(f'Cannot load invalid credential: "{' '.join(credential_parameters)}"')
                                                                                           ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py", line 18
    raise ValueError(f'Cannot load invalid credential: "{' '.join(credential_parameters)}"')
                                                                                           ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py", line 18
    raise ValueError(f'Cannot load invalid credential: "{' '.join(credential_parameters)}"')
                                                                                           ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py", line 23
    )
    ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py", line 23
    )
    ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py", line 23
    )
    ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py", line 25
    )
    ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py", line 25
    )
    ^
SyntaxError: f-string: expecting '}'

*** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py'...
  File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py", line 25
    )
    ^
SyntaxError: f-string: expecting '}'
I have noticed following errors while I was creating Gentoo package for Borgmatic 1.9.11. The issue was introduced in commit a0ba5b673b9e - `Add credential loading from file, KeePassXC, and Docker/Podman secrets.`. This happens only with Python 3.10.16 and 3.11.11, Python 3.12.9 and 3.13.2 seem to be ok. ``` python3.11 -m gpep517 install-wheel --destdir=/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install --interpreter=/usr/bin/python3.11 --prefix=/usr --optimize=all /var/tmp/portage/app-backup/borgmatic-1.9.11 /work/borgmatic-1.9.11_python3.11/wheel/borgmatic-1.9.11-py3-none-any.whl 2025-02-23 13:00:08,627 gpep517 INFO Installing /var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/wheel/borgmatic-1.9.11-py3-none-any.whl into /var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_p ython3.11/install *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py", line 24 raise ValueError(f'Cannot load invalid secret name: "{' '.join(credential_parameters)}"') ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py", line 24 raise ValueError(f'Cannot load invalid secret name: "{' '.join(credential_parameters)}"') ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/container.py", line 24 raise ValueError(f'Cannot load invalid secret name: "{' '.join(credential_parameters)}"') ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py", line 18 raise ValueError(f'Cannot load invalid credential: "{' '.join(credential_parameters)}"') ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py", line 18 raise ValueError(f'Cannot load invalid credential: "{' '.join(credential_parameters)}"') ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/file.py", line 18 raise ValueError(f'Cannot load invalid credential: "{' '.join(credential_parameters)}"') ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py", line 23 ) ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py", line 23 ) ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/keepassxc.py", line 23 ) ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py", line 25 ) ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py", line 25 ) ^ SyntaxError: f-string: expecting '}' *** Error compiling '/var/tmp/portage/app-backup/borgmatic-1.9.11/work/borgmatic-1.9.11_python3.11/install/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py'... File "/usr/lib/python3.11/site-packages/borgmatic/hooks/credential/systemd.py", line 25 ) ^ SyntaxError: f-string: expecting '}' ```
arkamar commented 2025-02-23 14:08:06 +00:00
Author
Copy link

The same nested quotes in f-string can be used since PEP 701 introduced in Python 3.12.

The same nested quotes in f-string can be used since [PEP 701](https://docs.python.org/3.12/whatsnew/3.12.html#pep-701-syntactic-formalization-of-f-strings) introduced in Python 3.12.
witten commented 2025-02-23 17:10:52 +00:00
Owner
Copy link

Ugh, thank you for filing this one! I really need to get some automated tests against older versions of Python. I've fixed the issue and will put out an updated release momentarily.

Ugh, thank you for filing this one! I really need to get some automated tests against older versions of Python. I've fixed the issue and will put out an updated release momentarily.
witten commented 2025-02-23 18:01:52 +00:00
Owner
Copy link

Released in borgmatic 1.9.12!

Released in borgmatic 1.9.12!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
parallel-borgmatic
command-hook-steps
2.1.7
2.1.6
2.1.5
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.9.14
1.9.13
1.9.12
1.9.11
1.9.10
1.9.9
1.9.8
1.9.7
1.9.6
1.9.5
1.9.4
1.9.3
1.9.2
1.9.1
1.9.0
1.8.14
1.8.13
1.8.12
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
borgmatic-collective/borgmatic#1005
No description provided.