borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
9
74
Fork 55
Code Issues 55 Pull requests 4 Releases 160 Packages 1 Activity Actions 1

Add a dash to the prefix of the randomly named temporary directory to improve readability (#937).

Browse source
This commit is contained in:
Dan Helfman 2024-11-16 11:26:24 -08:00
commit b0cad58d6c
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
borgmatic/config/paths.py
View file

@ -70,7 +70,8 @@ class Runtime_directory:
self.temporary_directory = None
else:
self.temporary_directory = tempfile.TemporaryDirectory(
prefix='borgmatic', dir=os.environ.get('TMPDIR') or os.environ.get('TEMP') or '/tmp'
prefix='borgmatic-',
dir=os.environ.get('TMPDIR') or os.environ.get('TEMP') or '/tmp',
)
runtime_directory = self.temporary_directory.name

6
tests/unit/config/test_paths.py
View file

@ -101,7 +101,7 @@ def test_runtime_directory_falls_back_to_tmpdir_and_adds_temporary_subdirectory_
temporary_directory = flexmock(name='/run/borgmatic-1234')
temporary_directory.should_receive('cleanup').once()
flexmock(module.tempfile).should_receive('TemporaryDirectory').with_args(
prefix='borgmatic', dir='/run'
prefix='borgmatic-', dir='/run'
).and_return(temporary_directory)
with module.Runtime_directory({}) as borgmatic_runtime_directory:
@ -119,7 +119,7 @@ def test_runtime_directory_falls_back_to_temp_and_adds_temporary_subdirectory_th
temporary_directory = flexmock(name='/run/borgmatic-1234')
temporary_directory.should_receive('cleanup').once()
flexmock(module.tempfile).should_receive('TemporaryDirectory').with_args(
prefix='borgmatic', dir='/run'
prefix='borgmatic-', dir='/run'
).and_return(temporary_directory)
with module.Runtime_directory({}) as borgmatic_runtime_directory:
@ -137,7 +137,7 @@ def test_runtime_directory_falls_back_to_hard_coded_tmp_path_and_adds_temporary_
temporary_directory = flexmock(name='/tmp/borgmatic-1234')
temporary_directory.should_receive('cleanup').once()
flexmock(module.tempfile).should_receive('TemporaryDirectory').with_args(
prefix='borgmatic', dir='/tmp'
prefix='borgmatic-', dir='/tmp'
).and_return(temporary_directory)
with module.Runtime_directory({}) as borgmatic_runtime_directory: