• Joined on 2025-03-13
VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-25 18:56:36 +00:00
Add Borg 1.4.1 features

I tested it on Borg 1.4.1, and you were right, the --dry-run flag isn't getting passed on to borg. I have made appropriate changes to fix it.

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-25 18:52:37 +00:00
1cde65b4eb fix dry run not working borg 1.4.1+
VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-25 17:30:52 +00:00
Add Borg 1.4.1 features

I'll try to test it out today if possible, otherwise, in the morning. Thanks.

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-25 17:26:34 +00:00
4e05539825 add review changes
VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-25 17:12:34 +00:00
Add Borg 1.4.1 features

So from the code I can tell that if it's say borg 1.4.1+ then the condition will be True (not necessarily true value, if i'm correct this will have dry-run flag as value) and False (not True)…

VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-25 17:00:26 +00:00
Add Borg 1.4.1 features

I have made those changes to the tests.

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-25 16:59:36 +00:00
d17aa3e7cc review changes
VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-25 16:35:10 +00:00
Add Borg 1.4.1 features

Yes, from what I understand, if the --dry-run flag is passed to borgmatic, then global_arguments.dry_run is present and not None.

This is the test screenshot: If borg version not supported…

VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-25 06:12:53 +00:00
Add Borg 1.4.1 features

@witten I've added the changes and modified the tests for the same.

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-25 06:11:23 +00:00
1ac51e34bc pass dry run flag
VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-23 17:37:24 +00:00
Add Borg 1.4.1 features

Ok so if I understand it correctly as of right now in all borgmatic actions, global_arguments.dry_run is checked, ie the presence of a --dry-run flag from argparse arguments, if present then…

VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-23 02:48:57 +00:00
Add Borg 1.4.1 features

I have made the requested changes and added version check before using --dry-run flag for borg compact.

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-23 02:42:22 +00:00
27a2bbc231 add --dry-run feature check
dbf1d0946a make review changes
Compare 2 commits »
VandalByte commented on pull request borgmatic-collective/borgmatic#1081 2025-04-20 05:07:50 +00:00
Add Borg 1.4.1 features

I've verified the --dry-run flag does work in borg2

image.png

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-20 04:30:09 +00:00
2078527539 add BORG_USE_CHUNKS_ARCHIVE
620bf52e01 add prune test
Compare 2 commits »
VandalByte created pull request borgmatic-collective/borgmatic#1081 2025-04-20 02:46:06 +00:00
WIP: Add Borg 1.4.1 features
VandalByte commented on issue borgmatic-collective/borgmatic#1078 2025-04-19 18:10:52 +00:00
Add Borg 1.4.1 feaures

If you haven't started the PR work for this yet, I'd be happy to take it on.

Edits to config and then passing the relevant flags to borg prune.

It's already being taken care of here,…

VandalByte commented on issue borgmatic-collective/borgmatic#1078 2025-04-19 04:52:09 +00:00
Add Borg 1.4.1 feaures

First: This requires only edits to to config right? Add those two options to the rest of the [bunch](fdb08b6c56

VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-19 04:45:01 +00:00
fdb08b6c56 add 13weekly and 3monthly quarterly
VandalByte pushed to dev-newborgstuff at VandalByte/borgmatic 2025-04-19 04:04:37 +00:00