No, I am not working on this code anymore. Please feel free to assign this to someone else @witten
syslog output
I think I have completed most of the tests. So please review. 😄
syslog output
In tests/unit/test_logger.py Line 316
flexmock(module.os.path).should_receive('exists').with_args('/dev/log').and_return(True)
shouldn't this be
flexmock(module.o…
syslog output
It's the test_run_configuration_bails_for_monitor_log_soft_failure test in tests/unit/commands/test_borgmatic.py, line 119
syslog output
I have updated the tests. However I faced one issue. It seems to me that in the tests in the file tests/unit/commands/test_borgmatic.py, for the line where we set the monitoring_verbosity,
`…
syslog output
While writing unit tests for Healthchecks in tests/unit/hooks/test_healthchecks.py, I noticed that monitoring_log_level is set to 1 while monitoring_log_level should actually correspond…
syslog output
Considering the second option of not sending logs if --monitoring-verbosity is set to -2, I have disabled the addition of Forgetful_buffering_handler.
syslog output
For verbosity level for monitoring services, I see that for all the definitions of ping_monitor :
def ping_monitor(hook_config, config_filename, state, monitoring_log_level,…
syslog output
Yes I agree, adding verbosity level -2 will be better. Its better to show log level (as done by syslog) in output instead of indicating the log level by its colour (from console_logs) to…
syslog output
Yes it will be good for consistency. Otherwise we will have to document around this.
syslog output
In the arguments, is it necessary to mention default=False if action='store_true' is passed? From the docs it seems unnecessary to…
Also, if --repository is not mentioned, by default, it should delete all repositories or if an archive is mentioned, it should delete that archive from all configured repositories, right?
I have a question in general, between Borg 1 and Borg 2, a lot of commands have changed. For example between these versions,
Yes, I have "format-on-save" turned-on on VSCode with the default Python formatter but it didn't pickup the rule. Though I would be happy to setup pre-commit rules to run black (with custom rules)…
Sorry that was in issue on my part 😅 . The tests work fine. I was checking if the state existed in the values instead of the keys of the dict MONITOR_STATES_TO.... I have updated the code…