Seems valid. We might just have the call return a list of either pathlib or Popen objects and check for the type of all of them.…
So I think the general implementation of a snapshot hook should be pretty simple: We need a snapshot function that allows the hook to create snapshots and return a list of paths that are to be…
Well I was thinking of having the zfs hook work the following: Have a zfs option in the config file (Only a simple on/off) Have a [zfs user property](https://openzfs.github.io/openzfs-docs/man/ma…
@witten Architectural question: Where in the code would you like this to be implemented? Afaik the hook system is not really powerful enough to handle this as we have to manipulate which…
One more thing: We have to check that we do not back up anything twice, so backing up a dataset DATA/test mounted at /test and /test in source_directories should either result in an error or be…
We could implement this for zfs at least by doing the following for each dataset:
- Create a snapshot
- Mount said snapshot under /tmp/borgmatic_zfs_fakeroot/MOUNTPOINT
- Pass path as…
/usr/share excluded when it should not be
I'm not 100% sure but sh:*/[Ss]hare/ should match /usr/share (it's on line 11 in your excludes).
/usr/share excluded when it should not be
Can you post you full config (minus secrets) and the output of borgmatic -v 2 here?
It looks like the compatible api should not be to hard as podman docs state "This documentation describes the Podman v2.x+ RESTful API. It…
Ok the plan has changed a bit. Docker does not support this via the cli at all, so I think the cli hook can reasonably be renamed to be podman only (We should simply put a label on it saying: THIS…
No we really don't have 4 setups, we have two:
- Inside a container
- Outside a container I think docker/podman should not make a lot of difference, at least the cli tools are compatible (at…
So a bit of a technical question: How will we call unshare()? I did not consider that to be a problem but after looking at os in python where I expected to find it it does not look like python…
Would you be opposed to having a cli and a socket implementation @witten ? I think we should look at something like containers/podman-py for the socket…
Well what I had in mind would use unshare() to create a private mount namespace, unmount the old mount and mount the snapshot (I know this works in zfs at least). But what if someone would like…
But borgmatic can already do that right? Afaik it should support reading things from the env so why add a feature to do that manually for one field? Is there any limitation to running your…
Just this I will do all the information separately later and I think there is a lot of room for discussion on how and were to implement the rest.
Fixed now