I would probably only print PRETTY_NAME if available, maybe NAME and VERSION as fallback and nothing else otherwise as the distro probably matters least for debugging and it should be fine…
Ok so I have most of this done, the only roadblock I have hit is how to deal with borg versions. The issue is that a user can have as many different borg versions installed as they want (not that…
One question that remains is: Where will we implement this? Does borgmatic log this every time someone runs with loglevel 2? I personally think for the os and version info it would be good to…
I have looked at some of the options for getting os and env info and the best choice seems to be using pythons platform for that. It basically ticks all the boxes so far:
- Maintained without…
We could start by getting the distro and the version from /etc/os-release for linux as almost all distros have that file afaik. Borg otherwise supports many more unix like operating systems. I…
The docs you added look great. I don't think I have anything to add so far but I would like to say that I have only tested the hook against a local grafana loki instance and I have not yet…
I updated the branch based on what you wrote @witten
Mainly whitespace etc. It's more consistent this way and we don't have to worry about anything formatting related.
I changed this test to makes more sense. It now checks that the buffer gets the exact message I expect.
Thats fixed now
@witten Unit tests are done now.
Tests are coming as soon as you are fine with the current state of the hook and the mayor questions are resolved.
I don't think adding a entry that we are bailing is useful here as I added the entry for every time we flush the buffer now (which is at least once per program).
Well I am trying to not hit the max request size limits of a lot of loki instances that run behind e.g. nginx. I think it is much better for large volumes of logs to be pushed incrementally…
Yes there is a reason for doing it this way. First of all as far as I am aware the function is just supposed to inform the monitoring app of the current state. If we used logger.info() the…
I wanted to ask about this anyway: Is the hostname of the system used anywhere else so we can have consistent naming? Not that it matters much for this as users can change the hostname label…
Not really. Grafana loki labels are rarely longer than a single word and the placeholders can be compared to what grafana themself have implemented in promtail which is their loki log agent. The…
So I have basically finished the core implementation now and I'm working on the configuration and have a question about the schema. Is it possible to allow a dict of arbitrary strings as key/value…