I pushed the changes but I still have 2 issues with the tests (ran wit tox -- tests/unit/commands/test_borgmatic.py
):
test_run_actions_adds_action_name_to_hook_context
:
AttributeError:…
Honestly, with the one wording change
Sorry but I don't see the change you are talking about. Maybe you forgot to finish the code review on Gitea?
Do you want me to set to TODO
(1.7.13?…
Well, here goes my PR: #695 (hope it will pass the quality check ;))
Thanks, I'll try to submit a PR with tests.
True 👍
I wanted to keep the action_names
as a list as long as possible ;) (and my Python skills failed me for the key for key in arguments.keys()
part too :P)
For a start the interpolated variable is fine start, it gives the user all the card to shape it's hooks commands for it's own use case without adding complexity to borgmatic.
Something like…
(Saw your reply after I finished my tries and error)
Thanks for taking the time to file this! It's helpful to see exactly the shell commands you're running from hooks.
It works,…
My attempt to check for a borgfs mount before trying to unmount my remote folder:
hooks:
before_actions:
- test -d "/mnt/network_folder"