• Joined on 2023-03-21
C-Duv commented on pull request borgmatic-collective/borgmatic#695 2023-05-14 23:22:59 +00:00
WIP: Adding "actions" runtime variable #657

I pushed the changes but I still have 2 issues with the tests (ran wit tox -- tests/unit/commands/test_borgmatic.py):

test_run_actions_adds_action_name_to_hook_context:

AttributeError:…

C-Duv commented on pull request borgmatic-collective/borgmatic#695 2023-05-14 17:14:47 +00:00
WIP: Adding "actions" runtime variable #657

I get it: wording was changed.

C-Duv commented on pull request borgmatic-collective/borgmatic#695 2023-05-14 17:14:19 +00:00
WIP: Adding "actions" runtime variable #657

Done :)

C-Duv pushed to feat/adding_action_names_to_hook_context at C-Duv/borgmatic 2023-05-14 17:13:09 +00:00
f17fde399e Add "actions" runtime variable (#657)
C-Duv commented on pull request borgmatic-collective/borgmatic#695 2023-05-14 11:54:15 +00:00
WIP: Adding "actions" runtime variable #657

Honestly, with the one wording change

Sorry but I don't see the change you are talking about. Maybe you forgot to finish the code review on Gitea?

Do you want me to set to TODO (1.7.13?…

C-Duv commented on issue borgmatic-collective/borgmatic#657 2023-05-11 00:01:24 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?

Well, here goes my PR: #695 (hope it will pass the quality check ;))

C-Duv created pull request borgmatic-collective/borgmatic#695 2023-05-11 00:00:05 +00:00
WIP: Adding "actions" runtime variable #657
C-Duv pushed to feat/adding_action_names_to_hook_context at C-Duv/borgmatic 2023-05-10 23:47:36 +00:00
e8bcae3916 Add "actions" runtime variable (#657)
C-Duv created branch feat/adding_action_names_to_hook_context in C-Duv/borgmatic 2023-05-10 23:47:36 +00:00
C-Duv created repository C-Duv/borgmatic 2023-05-10 23:43:37 +00:00
C-Duv commented on issue borgmatic-collective/borgmatic#657 2023-04-10 14:31:39 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?

Thanks, I'll try to submit a PR with tests.

C-Duv commented on issue borgmatic-collective/borgmatic#657 2023-03-25 11:07:19 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?

True 👍

I wanted to keep the action_names as a list as long as possible ;) (and my Python skills failed me for the key for key in arguments.keys() part too :P)

C-Duv commented on issue borgmatic-collective/borgmatic#657 2023-03-24 01:04:08 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?

For a start the interpolated variable is fine start, it gives the user all the card to shape it's hooks commands for it's own use case without adding complexity to borgmatic.

Something like…

C-Duv commented on issue borgmatic-collective/borgmatic#657 2023-03-22 18:04:41 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?

(Saw your reply after I finished my tries and error)

Thanks for taking the time to file this! It's helpful to see exactly the shell commands you're running from hooks.

It works,…

C-Duv commented on issue borgmatic-collective/borgmatic#657 2023-03-22 17:52:13 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?

My attempt to check for a borgfs mount before trying to unmount my remote folder:

hooks:
    before_actions:
        - test -d "/mnt/network_folder" 
C-Duv opened issue borgmatic-collective/borgmatic#657 2023-03-22 12:57:24 +00:00
Hooks to mount/umount remote (e.g. NFS) folder containing the Borg repository?