Just checking in... Do you plan to get back to this one? If not, no problem, just please let me know. Thanks!
I will be back on DEC 1st and will definitely complete this.
Should I also add a test where password_transport = pipe will be ignored when format is directory?
So, should I add something like this in dump_data_sources code ?
is_directory_format = database.get('format') == 'directory'
password_transport = ( 'environment' if is_directory_format…
One more bit of scope creep to consider. There are end-to-end tests for MySQL, currently in `tests/end-to-end/…
Kind of a pain, I know. But I'm fine if you want to do this in a separate PR instead of in this one.
I am porting the changes to MariaDB in this PR itself.
There is one test failure test_dump_data_sources_dumps_each_database() which I have been debugging from last 2 days. Only thing I could figure out is 'foo' database is not dumped which should…
2d8b455e44
Switched from pipx to uv for installing development tools, and added tox-uv for speeding up test environment creation.
9a80fec91b
When running tests, use Ruff for faster and more comprehensive code linting and formatting.
Yes writing tests after factoring out to separate functions is a lot easier. I want to just confirm once: password_transport for all the 3 functions should be environment, only so directory format…
I did the round-tripping...Dump and restore are working as expected.Is refactoring upto the mark?? I am working on failing tests and adding new tests now.
@witten I have added restore. Is this the expected process flow for restore??
Currently I have restore implemented considering only one conditional if data_source.get(format)==directory, that restores from borgmatic_runtime_directory , schema and tables separately. Should…